Skip to content

refactor GetProviders #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Andrew44Ashraf wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor GetProviders #34

Andrew44Ashraf wants to merge 1 commit into from
+74 −30

Conversation

@Andrew44Ashraf
Copy link
Collaborator

@Andrew44Ashraf Andrew44Ashraf commented Jan 1, 2022

Fixes # .

Changes proposed in this pull request:

  • refactoring GetProviders method
  • added a json file containing providers name and attributes (acting as a datastore)
  • validating the config.yaml against the providers from the json file dynamically
  • creating providers object dynamically

@Andrew44Ashraf Andrew44Ashraf added the enhancement New feature or request label Jan 2, 2022
@abahmed abahmed marked this pull request as draft August 25, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amgadramses amgadramses Awaiting requested review from amgadramses

@abahmed abahmed Awaiting requested review from abahmed abahmed is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Andrew44Ashraf