[Feature] Install necessary packages #2
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekkrthakur
requested changes
Sep 9, 2020
colabcode/code.py
Outdated
|
|
||
| def _install_packages(self): | ||
| for package in self.packages: | ||
| print(f'Installing {package}...') |
There was a problem hiding this comment.
use logger.info instead of print here please
| self._run_code() | ||
|
|
||
There was a problem hiding this comment.
some extra space? would be nice to get rid of this
colabcode/code.py
Outdated
| @@ -1,16 +1,20 @@ | |||
| import os | |||
| import subprocess | |||
| from pyngrok import ngrok | |||
|
|
|||
| import subprocess | |||
There was a problem hiding this comment.
subprocess is already imported
|
Please let me know when this is ready. There is a conflict too now :) |
|
|
Is there anything else to change? |
|
conflicts. update readme please. |
|
README.md conflicts resolved. |
mmphego
reviewed
Sep 11, 2020
|
@mmphego flake8 and black works good. |
Borda
reviewed
Nov 19, 2020
Comment on lines
+28
to
+29
| if self.packages: | ||
| self._install_packages() |
There was a problem hiding this comment.
Suggested change
| if self.packages: | |
| self._install_packages() | |
| self._install_packages() |
| @@ -58,3 +65,8 @@ def _run_code(self): | |||
| ) as proc: | |||
| for line in proc.stdout: | |||
| print(line, end="") | |||
|
|
|||
| def _install_packages(self): | |||
| for package in self.packages: | |||
There was a problem hiding this comment.
Suggested change
| for package in self.packages: | |
| if not self.packages: | |
| return | |
| for package in self.packages: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install necessary packages with
ColabCode(port=10000, packages=['torchaudio', 'pytorch_lightning'])