-
Notifications
You must be signed in to change notification settings - Fork 43
Chat: Update chat docs for single channel changes #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: Update chat docs for single channel changes #2524
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Can we update the examples in this PR as well, or did you have that planned for a separate one? |
I think it's worth doing those as separate PR's, we are merging this into an integrations branch first anyway, so I'll make some tickets for that :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments / questions 🙂
content/chat/rooms/index.textile
Outdated
|
||
h2(#create). Create or retrieve a room | ||
|
||
Users send messages to a room and subscribe to the room in order to receive messages. Other features, such as indicating which users are online, or which users are typing are configured as part of a room's options. | ||
Users send messages to a room and subscribe to the room in order to receive messages. Other features, such as indicating which users are online, or which users are typing can be configured as part of a room's options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the second sentence is correct here. Isn't typing enabled by default now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, I was trying to say here that those features can be configured (e.g. setting the heartbeat interval etc..), but maybe it seems like I'm suggesting they can be turned on/off. I'll reword this a bit :)
adc7024
to
448fc4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small comments that aren't blocking, LGTM.
11da147
into
integration/chat-single-channel
Description
CHA-916 and CHA-874
Chat is moving to a single channel, this includes changes to how features are enabled in the Chat SDK.
Checklist