Skip to content

NOISSUE- Remove certificate and key constraint for DTLS request #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dborovcanin merged 1 commit into from
Oct 29, 2025
Merged

NOISSUE- Remove certificate and key constraint for DTLS request #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ func main() {
rootCmd.PersistentFlags().StringVarP(&req.certFile, "cert-file", "C", "", "Client certificate file")
rootCmd.PersistentFlags().StringVarP(&req.keyFile, "key-file", "K", "", "Client key file")
rootCmd.PersistentFlags().StringVarP(&req.clientCAFile, "ca-file", "A", "", "Client CA file")
rootCmd.PersistentFlags().BoolVarP(&req.useDTLS, "use DTLS", "s", false, "Use DTLS")

if err := rootCmd.Execute(); err != nil {
log.Fatalf("Error executing command: %v", err)
Expand Down Expand Up @@ -225,18 +226,21 @@ type request struct {
certFile string
keyFile string
clientCAFile string
useDTLS bool
}

func (r *request) createDTLSConfig() (*piondtls.Config, error) {
if r.certFile == "" || r.keyFile == "" {
if !r.useDTLS {
return nil, nil
}
dc := &piondtls.Config{}
cert, err := tls.LoadX509KeyPair(r.certFile, r.keyFile)
if err != nil {
return nil, errors.Join(errors.New("failed to load certificates"), err)
if r.certFile != "" && r.keyFile != "" {
cert, err := tls.LoadX509KeyPair(r.certFile, r.keyFile)
if err != nil {
return nil, errors.Join(errors.New("failed to load certificates"), err)
}
dc.Certificates = []tls.Certificate{cert}
}
dc.Certificates = []tls.Certificate{cert}
rootCA, err := loadCertFile(r.clientCAFile)
if err != nil {
return nil, errors.Join(errors.New("failed to load Client CA"), err)
Expand All @@ -249,7 +253,6 @@ func (r *request) createDTLSConfig() (*piondtls.Config, error) {
return nil, errors.New("failed to append root ca tls.Config")
}
}
dc.InsecureSkipVerify = true
return dc, nil
}

Expand Down