Skip to content

Conversation

@dansharpe83
Copy link
Contributor

this is just an initial exploration to adding an ILogger to the library, to improve what we can see from logging libraries etc, to make it less of a black box.

I have only done one service for now, but if this gets approval then i can add it to the other services

@abuzuhri
Copy link
Owner

Can you solve the Conflict here

@dansharpe83
Copy link
Contributor Author

i have updated the merge conflicts, if you are ok with the principle, i can update the rest of the services to have the logger passed through to them, this should be done before this is merged

@abuzuhri
Copy link
Owner

Yes it's ok you can do it

@abuzuhri abuzuhri merged commit ca8dc79 into abuzuhri:main Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants