remove gomod2nix #19
remove gomod2nix #19
Conversation
acaloiaro
commented
Jan 1, 2025
acaloiaro
commented
- feat: factor out gomod2nix
- feat: factor out gomod2nix
acaloiaro
force-pushed
the
remove-gomod2nix
branch
from
f995c22 to
7d25a12
Compare
| in | ||
| import (fetchTree nixpkgs.locked) { | ||
| overlays = [ | ||
| (import "${fetchTree gomod2nix.locked}/overlay.nix") |
There was a problem hiding this comment.
Where did this overlay.nix go?
| darwin = build.overrideAttrs (old: | ||
| old | ||
| // { | ||
| GOOS = "darwin"; | ||
| GOARCH = "amd64"; | ||
| }); | ||
| linux32 = build.overrideAttrs (old: | ||
| old | ||
| // { | ||
| GOOS = "linux"; | ||
| GOARCH = "386"; | ||
| }); | ||
| x86_64-linux = build.overrideAttrs (old: | ||
| old | ||
| // { | ||
| GOOS = "linux"; | ||
| GOARCH = "amd64"; | ||
| }); | ||
| windows64 = build.overrideAttrs (old: | ||
| old | ||
| // { | ||
| GOOS = "windows"; | ||
| GOARCH = "amd64"; | ||
| }); |
There was a problem hiding this comment.
There is a lot of repetition here. You could extract a builder func that takes in the name, goos, goarch, map and build this object.
There was a problem hiding this comment.
Yeah agreed. My nixlang skills are not good and didn't think I'd get it done cleanly.
| module github.com/acaloiaro/ess | ||
|
|
||
| go 1.21 | ||
| go 1.23.1 |
There was a problem hiding this comment.
1.24.4 is in nixpkgs already. Latest one is 1.24.6
| "text/template" | ||
|
|
||
| "github.com/hashicorp/go-envparse" | ||
| "github.com/acaloiaro/go-envparse" |
There was a problem hiding this comment.
What did you need to override?
There was a problem hiding this comment.
Hashicorp's go-envparse doesn't support env files that include non-env stuff, like comments, which ess requires.
Under the hood, nothing changed in acaloiaro/go-envparse, but I removed the replace in its go.mod that renamed it from github.com/hashicorp/go-envparse => github.com/acaloiaro/go-envparse.
I'm assuming that project won't be merging my changes, so I'm making mine I hard fork.
There was a problem hiding this comment.
Doesn't hurt to submit a patch, though
| version = "2.14.1"; | ||
| src = ./.; | ||
| pwd = ./.; | ||
| vendorHash = "sha256-oIA1LTBvkA26ferZI+uOipLE2/wZr2XKjGfESuD/cPk="; |
There was a problem hiding this comment.
I find it much easier to just vendorize dependencies instead.
