This repository was archived by the owner on Nov 19, 2020. It is now read-only.
Optimise data structures being used by Graham Convex Hull implementation #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Josh, Many thanks for the contribution! (and sorry for the delay in reviewing it - there was nothing wrong with your PR, it was just that I was in holidays for those past three weeks. It is a very welcome improvement to the framework!) Best regards, |
|
Hi Cesar, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously submitted to AForge.NET repo @ andrewkirillov/AForge.NET#22 but then saw that it seems to be maintained here now :)
This is purely an optimisation, and in no way intends to change the behavior of the algorithm.
The implementation of a Graham Scan is currently using lists internally. The algorithm removes elements from these lists at points other than the end, which can be a very expensive operation. This PR changes the internal collections used to be better suited to the operations performed on them.