Skip to content

Conversation

@rockaxorb13
Copy link

Summary

This PR standardizes the test file naming convention for the fragile-goods template.

It merges the non-standard logic-minutes.feature and logic-seconds.feature files into a single logic.feature file, refactoring some logic but having no change in functionality which aligns the template with the rest of the repository. This ensures CI/CD tools and test runners can automatically discover and execute these tests.

Changes

  • Merged Files: Combined logic-minutes.feature and logic-seconds.feature into src/fragile-goods/test/logic.feature.
  • Refactored Logic: - Standardized the Background to use the 10-minute delivery schedule contract.
    • Updated the "Seconds" scenarios to use a delivery duration of 10m 11s (instead of 11s). This preserves the intended "Late Delivery" failure logic while adhering to the 10-minute contract limit defined in the background.
  • Cleanup: Deleted the old non-standard feature files.

Related Issues

Verification

Ran npm test -- --filter fragile-goods locally.
Result: 7 scenarios (7 passed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant