-
Notifications
You must be signed in to change notification settings - Fork 51
Add more integration tests for run_nifti_insertion.py #1266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more integration tests for run_nifti_insertion.py #1266
Conversation
@@ -175,7 +176,8 @@ def __init__(self, loris_getopt_obj, script_name): | |||
# --------------------------------------------------------------------------------------------- | |||
# Create the pic images | |||
# --------------------------------------------------------------------------------------------- | |||
self._create_pic_image() | |||
if self.create_pic_bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bug found when implementing the tests 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, those are certainly very exhaustive tests ! Congrats for the work !
Two minor comments:
- Query function naming.
- Some unnecessary
None
-checks that can be removed.
If you agree with those, just apply the advised changes and you can merge without re-review.
No description provided.