Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OcBootManagementLib: Convert naming from External System Boot to Unmanaged Boot #552

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

mikebeaton
Copy link
Contributor

@mikebeaton mikebeaton commented Sep 2, 2024

External is already used for:

  • External picker (as opposed to builtin)
  • External file system (as in, which icon to show in Canopy, or whether to mark entry “ (external)” in builtin picker)
  • External Tool (user defined tool)
  • External OS (user defined entry; it is also used for entries from boot entry protocol*)
  • External Boot System

This PR suggests changing the last one to Unmanaged Boot This is a PR split off from #549. I found it easier to work on that after these changes, which is why it was included in there in the first place.

EDIT: See additional explanation in comment below.

(*I only spotted this starred point while separating out this PR. I wonder if these should really have been Other OS instead of External OS all along? Like non-macOS, non-Windows blessed entries?)

@@ -1495,7 +1495,7 @@ BootPickerEntriesSet (
}

break;
case OC_BOOT_EXTERNAL_SYSTEM:
case OC_BOOT_UNMANAGED:
Copy link
Contributor Author

@mikebeaton mikebeaton Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that OC_BOOT_EXTERNAL_TOOL and OC_BOOT_SYSTEM are present a few lines above, if you expand upwards. (While the previous name OC_BOOT_EXTERNAL_SYSTEM was similar to both these, I believe the meaning is not similar.)

EDIT: i.e. OC_BOOT_SYSTEM is for system actions, which I take it 'do something' to the system (e.g. reset nvram), but probably 'do something' should be construed narrowly enough to avoid including 'boot an OS'. For the existing 'External' Tool and 'External' OS I think 'external' more or less means 'provided by the user rather than detected by OpenCore'. Whereas the new 'OC_BOOT_EXTERNAL_SYSTEM' basically means 'boot something, but don't use OpenCore to boot it', which is why I thought 'OC_BOOT_UNMANAGED' might be better, avoiding the multiple use of 'external' mentioned in OP above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that feels ok to me.

@vit9696 vit9696 merged commit 184f3e0 into acidanthera:master Oct 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants