Add support for AMD_CPU_EXT_FAMILY_1AH #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vit9696
reviewed
Sep 10, 2024
| tscFCvtn2tValue = DivU64x64Remainder ((1000000000ULL << 32), tscFCvtt2nValue, NULL); | ||
|
|
||
| } else if (CpuInfo->ExtFamily == 0xB) { | ||
|
|
There was a problem hiding this comment.
Why cannot we just add a 100 MHz fallback to the upper if?
There was a problem hiding this comment.
Can do. I had it split for testing incase further modification was required. I'll have it tested to ensure compatibility.
VS compiler does not like your change, could you please fix? |
vit9696
reviewed
Sep 11, 2024
| @@ -786,7 +815,12 @@ ScanAmdProcessor ( | |||
| if (MaxBusRatio == 0) { | |||
| Cpu->FSBFrequency = 100000000; // 100 MHz like Intel part. | |||
| } else { | |||
There was a problem hiding this comment.
better to change to else if, and not introduce a new level of indentation.
There was a problem hiding this comment.
Updated. Hopefully that fixes your concerns
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMD 9000 Series CPUs have changed from Family 19h to 1Ah.
Tested and confirmed to boot.