feat: target Rails 8.0 and require at least Ruby 3.2#601
Merged
Conversation
G-Rath
force-pushed
the
rails-8-stuff/support
branch
5 times, most recently
from
e9ac7c2 to
97f12fa
Compare
G-Rath
force-pushed
the
rails-8-stuff/support
branch
2 times, most recently
from
e2112a5 to
bcbd98d
Compare
G-Rath
force-pushed
the
rails-8-stuff/support
branch
from
d416916 to
eab43fa
Compare
G-Rath
commented
Jul 1, 2025
G-Rath
changed the title
G-Rath
commented
Jul 2, 2025
| "ActiveSupport::Logger.new(STDOUT)", | ||
| "ActiveSupport::Logger.new($stdout)" | ||
|
|
||
| insert_into_file! "config/environments/production.rb", |
G-Rath
commented
Jul 2, 2025
| # You should never use this because it just blindly sets headers without any actual | ||
| # checks; instead, whatever is handling the SSL-termination should be setting the | ||
| # appropriate headers to indicate that the request was actually SSL-terminated. | ||
| config.assume_ssl = false |
G-Rath
commented
Jul 2, 2025
|
|
||
| RUBY | ||
| end | ||
| gsub_file! "config/environments/production.rb", |
G-Rath
requested review from
JacobBriggsAckama,
brooke-m,
eoinkelly,
halles,
hopkincame,
joshmcarthur,
lukeify and
robotdana
joshmcarthur
approved these changes
Jul 9, 2025
lukeify
approved these changes
Jul 24, 2025
joshmcarthur
approved these changes
Jul 25, 2025
G-Rath
force-pushed
the
rails-8-stuff/support
branch
from
7706332 to
da2378a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #589
Resolves #588
Resolves #587
Closes #586
Closes #573
Resolves #570
Resolves #569