-
Notifications
You must be signed in to change notification settings - Fork 367
New author system UI changes #6824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master-new-author-system
Are you sure you want to change the base?
Conversation
|
Why is the build failing? "No such file or directory" error for people.yaml |
|
Because it was created before the transitioned data was merged into |
|
Weird, but why did restarting the jobs not help... let's see if merging the base in helps |
|
I also assume this PR should be a draft at this stage, and not ready for review? |
|
Build successful. Some useful links:
This preview will be removed when the branch is merged. |
I think so—and this will require updating the author page template. |
Oh, to remove the checkmark from verified-no-orcid folks? I'll do that now. |
|
Title text for the ORCID icon that might help address @mbollmann's concern: "ORCID profile (some papers below may be guesses if they were submitted without ORCID iD)" |
Sure, I can add that. I saw that you had addressed it in the documentation, but I'm happy to make this more visible. |
Especially because the verification page documenting this will not be linked from an icon if there is an ORCID profile to link to. |
|
Went ahead and did it as it's a small change. |
|
Thanks. Fixed the logic on the question mark. Are we ready to merge this? I am going to write the blog post. |
|
@mjpost Sorry looks like we crossed commits. And you don't want to display any icon for legacy-verified pages? Don't we want to encourage ORCID submission for those? |
|
Hmm. My thinking from our three-way discussion is that we don't want three icons, but that that would naturally place legacy-verified people in a simple unlabeled bin. I guess we do want to encourage ORCID iD submission. I had in mind people who are verified but have passed away (unlikely to submit an ORCID iD, also not needed), but I suppose there are also many who have been legacy verified but are still publishing. Still, it seems like putting a question mark on their account, when we have verified them, isn't quite right. WHAT IF for legacy verified accounts
|
|
Yeah that sounds reasonable. I'll let you implement it. |
|
(Rebase on abde567 before making the changes?) |
Tangentially, this is exactly why I don't like the term "legacy verified". It implies that we don't support this way of verification anymore, which is simply not the case as there will always be authors who no longer publish, and we might verify them (without an ORCID) in the future if the need for disambiguation arises. |
mbollmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be lots of things in here that weren't here last time I checked, and I won't have time to review more closely this weekend.
|
Where is the CSS class |
I found it (don't understand scss; search for "text-verified" had failed) |
|
@mjpost Could you please restore the longer ORCID icon tooltip: "ORCID profile (some papers below may be guesses if they were submitted without ORCID iD)" |
|
@mjpost fixed a tag issue |
|
OK, it looks great! My only feedback now from the user side is the script variant issue I raised in #6807. Let me try fixing it on the front end (rather than messing with the Python library). |
|
@mbollmann did you want to take a final look at the code or is this ready to merge? |


The following are the tasks that should be done on this branch (see Hugo template changes):
Reconsidering: