Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added props eventOverlapping #1103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rahul-rayo
Copy link

@rahul-rayo rahul-rayo commented Sep 25, 2024

  • Added props eventOverlapping for events Side by Side instead of overlapping in day and week view.

before
Screenshot 2024-09-25 at 11 10 28 AM

after
Screenshot 2024-09-25 at 11 10 41 AM

 - Added props eventOverlapping for events Side by Side instead of overlapping in day and week view.
Copy link

vercel bot commented Sep 25, 2024

@rahul-rayo is attempting to deploy a commit to the Kazuya Gosho's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-big-calendar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 6:34am

@acro5piano
Copy link
Owner

@rahul-rayo Thanks! I'll take a look.

@acro5piano
Copy link
Owner

This is a breaking change so I'll bump a major version.

@acro5piano
Copy link
Owner

@rahul-rayo

Thank you so much for your pull request. I've took a look at the deployed preview and found the events are still overwrapping, although the option is enabled by default - can you provide an example in the storybook for visibility?

image

@rahul-rayo
Copy link
Author

Ok @acro5piano if i get time will do.

@acro5piano
Copy link
Owner

@rahul-rayo Thank you!

@arisyo13
Copy link
Contributor

Any plan to release this PR soon?

@acro5piano
Copy link
Owner

@arisyo13 Thanks for flagging this. If you create a complete PR forking from this one, it's welcome.
The biggest blocker is that this PR will breaks the default - which means major version bump.

@nizamozcan
Copy link

@arisyo13 Thanks for flagging this. If you create a complete PR forking from this one, it's welcome. The biggest blocker is that this PR will breaks the default - which means major version bump.

Hello,
Is there an update for this Pr?
I am having trouble with conflicting appointments

@acro5piano
Copy link
Owner

acro5piano commented Dec 10, 2024

@nizamozcan @Sheena1234
I think @rahul-rayo 's approach is correct, but the default is inverted - I will look into it when I have time, but if you can work on it please update rahul's PR (or create your own).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants