feat: Generated the constants file #1096

fusmanii · 2025-09-03T01:59:58Z

All constants are taken from constants repo so that there is only one source of truth

Resolves https://linear.app/uma/issue/ACX-4371/fully-generate-contract-configs-constants-from-constants-exports

See #1102 first which has the script

pxrl · 2025-09-04T14:15:13Z

script/utils/GenerateConstantsJson.ts

+  QUOTE_TIME_BUFFER,
+  FILL_DEADLINE_BUFFER,
+  ARBITRUM_MAX_SUBMISSION_COST,
+  AZERO_GAS_PRICE,


We can probably drop references to Aleph Zero because the Aleph Zero deployment is EoL now.

done 791d7e7

pxrl · 2025-09-04T14:16:37Z

script/utils/GenerateConstantsJson.ts

+}
+
+// Helper function to extract wrapped native tokens from TOKEN_SYMBOLS_MAP
+function extractWrappedNativeTokens(): { [key: string]: string } {


In the constants repo we define the native token symbol for each chain - feels like we could use that here to do something a bit more dynamic.

I was able to remove this function all together: 791d7e7

pxrl · 2025-09-04T14:17:28Z

script/utils/GenerateConstantsJson.ts

+function extractUsdceAddresses(): { [key: string]: string } {
+  const result: { [key: string]: string } = {};
+
+  for (const [chainId, address] of Object.entries(USDCe)) {


I don't think this is super reliable because the USDC symbol itself can be quite random. Zora has USDzC for example.

pxrl · 2025-09-04T14:18:11Z

script/utils/GenerateConstantsJson.ts

+}
+
+// Helper function to extract WGHO addresses
+function extractWghoAddresses(): { [key: string]: string } {


Integrating nativeToken from the constants repo would probably also help to remove a bespoke function like this one.

pxrl · 2025-09-04T14:19:17Z

script/utils/GenerateConstantsJson.ts

+    if (hubChainName) {
+      result[hubChainName] = {};
+      for (const [spokeChainId, addresses] of Object.entries(spokeChains)) {
+        const spokeChainName = Object.keys(CHAIN_IDs).find(
+          (key) => CHAIN_IDs[key as keyof typeof CHAIN_IDs] === Number(spokeChainId)
+        );
+        if (spokeChainName) {
+          result[hubChainName][spokeChainName] = addresses;
+        }
+      }
+    }


Thoughts on dropping the indentation by returning early if hubChainName is not defined?

pxrl · 2025-09-04T14:20:14Z

script/utils/GenerateConstantsJson.ts

+  for (const [chainId, domainId] of Object.entries(CIRCLE_DOMAIN_IDs)) {
+    const chainName = Object.keys(CHAIN_IDs).find(
+      (key) => CHAIN_IDs[key as keyof typeof CHAIN_IDs] === Number(chainId)
+    );
+    if (chainName) {
+      result[chainName] = domainId;
+    }
+  }


This pattern is a bit repetitive now - is there maybe some way to refactor such that the core functionality is generic? Or are the upstream objects themselves too bespoke for that?

pxrl · 2025-09-04T14:20:38Z

script/utils/GenerateConstantsJson.ts

+      QUOTE_TIME_BUFFER: QUOTE_TIME_BUFFER,
+      FILL_DEADLINE_BUFFER: FILL_DEADLINE_BUFFER,


Suggested change

QUOTE_TIME_BUFFER: QUOTE_TIME_BUFFER,

FILL_DEADLINE_BUFFER: FILL_DEADLINE_BUFFER,

QUOTE_TIME_BUFFER,

FILL_DEADLINE_BUFFER,

done: 791d7e7

pxrl · 2025-09-04T14:22:12Z

script/utils/constants.json

+    "LENS": -1,
+    "BOBA": -1,


ooc, rather than enumerating each chain w/ -1 for no OFT EID, could we just omit chains without an OFT EID?

good point, done: 791d7e7

pxrl · 2025-09-04T14:23:17Z

script/utils/constants.json

-    "POLYGON": "0x0d500B1d8E8eF31E21C99d1Db9A6444d3ADf1270",
-    "POLYGON_AMOY": "0xA5733b3A8e62A8faF43b0376d5fAF46E89B3033E",
-    "ZK_SYNC": "0x5AEa5775959fBC2557Cc8789bC1bf90A239D9a91",
    "OPTIMISM": "0x4200000000000000000000000000000000000006",
-    "OPTIMISM_SEPOLIA": "0x74A4A85C611679B73F402B36c0F84A7D2CcdFDa3",
-    "BASE": "0x4200000000000000000000000000000000000006",
-    "BASE_SEPOLIA": "0x999B45BB215209e567FaF486515af43b8353e393",
-    "LENS": "0x6bDc36E20D267Ff0dd6097799f82e78907105e2F",
-    "LINEA": "0xe5D7C2a44FfDDf6b295A15c148167daaAf5Cf34f",
-    "LINEA_SEPOLIA": "0x10253594A832f967994b44f33411940533302ACb",
-    "SCROLL_SEPOLIA": "0x5300000000000000000000000000000000000004",
-    "SCROLL": "0x5300000000000000000000000000000000000004",
+    "BSC": "0x2170Ed0880ac9A755fd29B2688956BD959F933F8",
    "UNICHAIN": "0x4200000000000000000000000000000000000006",
-    "UNICHAIN_SEPOLIA": "0x4200000000000000000000000000000000000006",
-    "ALEPH_ZERO": "0xB3f0eE446723f4258862D949B4c9688e7e7d35d3",
-    "BLAST": "0x4300000000000000000000000000000000000004",
-    "BLAST_SEPOLIA": "0x4200000000000000000000000000000000000023",
+    "POLYGON": "0x7ceB23fD6bC0adD59E62ac25578270cFf1b9f619",


We have different addresses for Polygon here - the new address is incorrect because it's WETH.

pxrl · 2025-09-04T14:24:42Z

script/utils/constants.json

-      "cctpMessageTransmitter": "0x0a992d191DEeC32aFe36203Ad87D7d289a738F81",
+      "cctpMessageTransmitter": "0x0a992d191deec32afe36203ad87d7d289a738f81",


It could be a good idea to split simple changes like this out to a separate PR - that'll help reduce the diff here and make it easier to review the subsequent address changes.

bmzig · 2025-09-04T15:02:06Z

script/utils/GenerateConstantsJson.ts

+}
+
+// Helper function to extract USDC addresses
+function extractUsdcAddresses(): { [key: string]: string } {


Two questions for this entire file:

Why are we setting the keys as the chain name? I would think it's a lot easier for foundry to know the network's chainId over the name of the network itself?

Maybe a stupid question, but these functions seem really complex for what they are doing. Why can't we just call JSON.stringify(USDC) and similar things for all of these other functions? I think adding this much code to just extract values from a map makes the script itself pretty rigid/hard to maintain.

Good idea, I updated the scripts to fetch by chainid instead 4677066

make every a lot cleaner

socket-security · 2025-09-05T14:57:48Z

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

linear · 2025-09-09T14:40:37Z

ACX-4371 Fully generate contract configs / constants from constants exports

fusmanii · 2025-09-09T15:35:38Z

script/utils/GenerateConstantsJson.ts

+// Generate the constants.json structure
+function generateConstantsJson() {
+  const constants = {
+    PUBLIC_NETWORKS,


@pxrl I imported the entire PUBLIC_NETWORKS which will allow me to get CCTP domain and OFT ids as well

Signed-off-by: Faisal Usmani <[email protected]>

fusmanii force-pushed the faisal/generate-constants-json branch from 98dcbfa to e78b1e9 Compare September 3, 2025 02:00

fusmanii marked this pull request as ready for review September 4, 2025 14:05

fusmanii requested review from mrice32, nicholaspai, pxrl and bmzig as code owners September 4, 2025 14:05

pxrl reviewed Sep 4, 2025

View reviewed changes

bmzig reviewed Sep 4, 2025

View reviewed changes

fusmanii force-pushed the faisal/generate-constants-json branch from 56f1e0f to ae04d5f Compare September 5, 2025 14:57

fusmanii mentioned this pull request Sep 9, 2025

feat(Foundry): zkSync support #1097

Open

fusmanii force-pushed the faisal/generate-constants-json branch from db95804 to 517c64b Compare September 9, 2025 15:28

fusmanii commented Sep 9, 2025

View reviewed changes

fusmanii requested review from pxrl and bmzig September 9, 2025 15:35

fusmanii mentioned this pull request Sep 10, 2025

feat(Foundry): Generate Constants script #1102

Open

fusmanii changed the base branch from master to faisal/generate-constants-json-script September 10, 2025 16:49

fusmanii added 3 commits September 10, 2025 12:51

feat: Generated the constants file

f2e5da1

Signed-off-by: Faisal Usmani <[email protected]>

Using const variable directly

44e3b87

Signed-off-by: Faisal Usmani <[email protected]>

Updated Constans.sol script to read by chainid instead of chain name

c8e42d3

Signed-off-by: Faisal Usmani <[email protected]>

fusmanii added 3 commits September 10, 2025 12:52

Updated constants.json keys

15cd2f4

Signed-off-by: Faisal Usmani <[email protected]>

Updated weth method name

c791e5a

Signed-off-by: Faisal Usmani <[email protected]>

Import entire PUBLIC_NETWORKS

3f13d19

Signed-off-by: Faisal Usmani <[email protected]>

fusmanii force-pushed the faisal/generate-constants-json branch from 517c64b to 3f13d19 Compare September 10, 2025 16:52

		QUOTE_TIME_BUFFER: QUOTE_TIME_BUFFER,
		FILL_DEADLINE_BUFFER: FILL_DEADLINE_BUFFER,

		"cctpMessageTransmitter": "0x0a992d191DEeC32aFe36203Ad87D7d289a738F81",
		"cctpMessageTransmitter": "0x0a992d191deec32afe36203ad87d7d289a738f81",

feat: Generated the constants file #1096

Are you sure you want to change the base?

feat: Generated the constants file #1096

Uh oh!

Conversation

fusmanii commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Sep 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fusmanii commented Sep 3, 2025 •

edited

Loading

socket-security bot commented Sep 5, 2025 •

edited

Loading