Skip to content

Commit

Permalink
chore: Decouple transfers-history from apiClient
Browse files Browse the repository at this point in the history
The ChainId definition is only a number, so define it directly in the
apiClient. Done in anticipation of the transfers-client implementation
being removed from the sdk, pending confirmation as to whether anyone
actually uses it.
  • Loading branch information
pxrl committed Jan 9, 2024
1 parent 043690f commit 4bac26c
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions src/apiClient/abstractClient.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { ethers } from "ethers";
import { ChainId } from "../transfers-history/adapters/web3/model";
import {
CoingeckoDataReturnType,
SuggestedFeeReturnType,
Expand Down Expand Up @@ -67,8 +66,8 @@ export default abstract class AbstractApiClient {
public abstract getSuggestedFees(
amount: ethers.BigNumber,
originToken: string,
toChainid: ChainId,
fromChainid: ChainId
toChainid: number,
fromChainid: number
): Promise<SuggestedFeeReturnType>;

/**
Expand All @@ -83,8 +82,8 @@ export default abstract class AbstractApiClient {
*/
public abstract getBridgeLimits(
token: string,
fromChainId: string | ChainId,
toChainId: string | ChainId
fromnumber: string | number,
tonumber: string | number
): Promise<BridgeLimitsReturnType>;

/**
Expand Down

0 comments on commit 4bac26c

Please sign in to comment.