Skip to content

Commit

Permalink
improve(BundleDataClient): Log about duplicate destination chain events
Browse files Browse the repository at this point in the history
We want to know when these events happen but we currently believe this is possible with the Indexed spoke pool client so we shouldn't throw.
  • Loading branch information
nicholaspai committed Feb 10, 2025
1 parent c617920 commit b0a7a23
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@across-protocol/sdk",
"author": "UMA Team",
"version": "4.1.8",
"version": "4.1.9",
"license": "AGPL-3.0",
"homepage": "https://docs.across.to/reference/sdk",
"files": [
Expand Down
12 changes: 10 additions & 2 deletions src/clients/BundleDataClient/BundleDataClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -992,7 +992,11 @@ export class BundleDataClient {
}
}
} else {
throw new Error("Duplicate fill detected");
this.logger.warn({
at: "BundleDataClient#loadDataFromScratch",
message: "Detected duplicate fill",
fill,
});
}
return;
}
Expand Down Expand Up @@ -1115,7 +1119,11 @@ export class BundleDataClient {
validatedBundleSlowFills.push(matchedDeposit);
}
} else {
throw new Error("Duplicate slow fill request detected.");
this.logger.warn({
at: "BundleDataClient#loadDataFromScratch",
message: "Detected duplicate slow fill request",
slowFillRequest,
});
}
return;
}
Expand Down

0 comments on commit b0a7a23

Please sign in to comment.