Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ComposableBridging simulation unit tests #472

Merged
merged 8 commits into from
Jan 16, 2024
Merged

feat: add ComposableBridging simulation unit tests #472

merged 8 commits into from
Jan 16, 2024

Conversation

james-a-morris
Copy link
Contributor

The purpose of these unit tests is to prevent regressions in our relayFeeCalculator as we make further changes.

@linear Linear
Copy link

linear bot commented Dec 12, 2023

ACX-1587 Unit test new gas simulations with mock contracts

@james-a-morris james-a-morris force-pushed the james/acx-1587-unit-test-new-gas-simulations-with-mock-contracts branch from 901ebf4 to 686f2b9 Compare December 12, 2023 20:08
@james-a-morris james-a-morris requested a review from pxrl December 12, 2023 20:15
nicholaspai
nicholaspai reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left several questions on the implementation but directionally +1 to unit testing this to prevent regressions!

@james-a-morris james-a-morris merged commit 1ba4398 into master Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholaspai nicholaspai nicholaspai approved these changes

@pxrl pxrl Awaiting requested review from pxrl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-a-morris @nicholaspai