Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove transfers-history implementation #490

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Jan 9, 2024

This is unsued code that will impose unnecessary work in the v2 -> v3 migration.

The ChainId definition is only a number, so define it directly in the
apiClient. Done in anticipation of the transfers-client implementation
being removed from the sdk, pending confirmation as to whether anyone
actually uses it.
@pxrl pxrl requested review from nicholaspai and amateima January 9, 2024 10:46
This is unsued code that will impose unnecessary work in the v2 -> v3
migration.
@pxrl pxrl force-pushed the pxrl/transfers-history branch from 8de5f81 to 2ff69b3 Compare January 9, 2024 10:47
@pxrl
Copy link
Contributor Author

pxrl commented Jan 9, 2024

To be merged subject to confirmation from @amateima

Base automatically changed from pxrl/smallApiClient to master January 9, 2024 22:16
Copy link
Contributor

@amateima amateima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

@pxrl pxrl merged commit 674de8c into master Jan 15, 2024
3 checks passed
@pxrl pxrl deleted the pxrl/transfers-history branch January 15, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants