-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Temporarily import select v3 typechain defs #494
Conversation
For preparing v3 SpokePoolClient functionality in advance of bumping contracts-v2.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we create a beta
version of the contracts-v2
and import things in the same pattern as the rest of the typechain imports?
I think it would be good to be as close to the end build as possible
[edit]: Not feasible, as discussed out of band. |
This is transparently compatible with v3 RelayData, which does not directly include the destinationChainId.
For preparing v3 SpokePoolClient functionality in advance of bumping contracts-v2.
These definitions should be removed as part of the eventual bump in contracts-v2.
fwiw, this is copied from the contracts-v2 typechain exports.