Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Temporarily import select v3 typechain defs #494

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Jan 15, 2024

For preparing v3 SpokePoolClient functionality in advance of bumping contracts-v2.

These definitions should be removed as part of the eventual bump in contracts-v2.

fwiw, this is copied from the contracts-v2 typechain exports.

For preparing v3 SpokePoolClient functionality in advance of bumping
contracts-v2.
@pxrl
Copy link
Contributor Author

pxrl commented Jan 15, 2024

Test is currently failing due to an unrelated issue with Infura. Issue resolved.

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we create a beta version of the contracts-v2 and import things in the same pattern as the rest of the typechain imports?

I think it would be good to be as close to the end build as possible

@pxrl
Copy link
Contributor Author

pxrl commented Jan 16, 2024

Could we create a beta version of the contracts-v2 and import things in the same pattern as the rest of the typechain imports?

I think it would be good to be as close to the end build as possible

I was hoping to avoid having to deal with 2 concurrent versions of the contracts-v2 package, but maybe it's better to take that approach. I think we can achieve it with selective dependency resolutions in yarn: https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions

[edit]: Not feasible, as discussed out of band.

This is transparently compatible with v3 RelayData, which does not
directly include the destinationChainId.
@pxrl pxrl changed the base branch from master to pxrl/fixOnly January 18, 2024 05:22
@pxrl pxrl merged commit d3a872e into pxrl/fixOnly Jan 19, 2024
3 checks passed
@pxrl pxrl deleted the pxrl/typechain branch January 19, 2024 13:23
@pxrl pxrl restored the pxrl/typechain branch January 19, 2024 13:29
@pxrl pxrl deleted the pxrl/typechain branch January 19, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants