Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: Remove toJSON/updateFromJSON functions #512

Merged
merged 1 commit into from
Jan 25, 2024
Merged

improve: Remove toJSON/updateFromJSON functions #512

merged 1 commit into from
Jan 25, 2024

Conversation

nicholaspai
Copy link
Member

No description provided.

@nicholaspai nicholaspai requested review from dohaki and pxrl January 25, 2024 13:59
james-a-morris
james-a-morris reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@james-a-morris james-a-morris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but since we're removing the updateFromJSON in the AcrosConfigStoreClient we may also want to remove it from the SpokePoolClient.

I was looking at an old commit, this is already removed. LGTM

@nicholaspai nicholaspai merged commit fd22f6a into master Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-a-morris james-a-morris james-a-morris left review comments

@pxrl pxrl pxrl approved these changes

@dohaki dohaki Awaiting requested review from dohaki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholaspai @james-a-morris @pxrl