improve(BundleDataClient,SpokePoolClient): Log about duplicate events and delete getLatestProposedBundleData

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@across-protocol/sdk",
   "author": "UMA Team",
-  "version": "4.1.8",
+  "version": "4.1.9",
   "license": "AGPL-3.0",
   "homepage": "https://docs.across.to/reference/sdk",
   "files": [

src/clients/BundleDataClient/BundleDataClient.ts

@@ -992,7 +992,11 @@ export class BundleDataClient {
                   }
                 }
               } else {
-                throw new Error("Duplicate fill detected");
+                this.logger.warn({
+                  at: "BundleDataClient#loadDataFromScratch",
+                  message: "Detected duplicate fill",
+                  fill,
+                });
               }
               return;
             }
@@ -1115,7 +1119,11 @@ export class BundleDataClient {
                   validatedBundleSlowFills.push(matchedDeposit);
                 }
               } else {
-                throw new Error("Duplicate slow fill request detected.");
+                this.logger.warn({
+                  at: "BundleDataClient#loadDataFromScratch",
+                  message: "Detected duplicate slow fill request",
+                  slowFillRequest,
+                });
               }
               return;
             }

src/clients/SpokePoolClient.ts

@@ -656,6 +656,21 @@ export class SpokePoolClient extends BaseAbstractClient {
         }
 
         if (this.depositHashes[getRelayEventKey(deposit)] !== undefined) {
+          // Sanity check that this event is not a duplicate, even though the relay data hash is a duplicate.
+          const allDeposits = this._getDuplicateDeposits(deposit).concat(this.depositHashes[getRelayEventKey(deposit)]);
+          if (
+            allDeposits.some((e) => {
+              return e.transactionHash === deposit.transactionHash && e.logIndex === deposit.logIndex;
+            })
+          ) {
+            this.logger.warn({
+              at: "SpokePoolClient#update",
+              chainId: this.chainId,
+              message: "Duplicate deposit found with same transaction hash and log index",
+              deposit,
+            });
+            continue;
+          }
           assign(this.duplicateDepositHashes, [getRelayEventKey(deposit)], [deposit]);
           continue;
         }