Conversation
|
the riftmachclient is the ipc client. since the menu bar icon is running in the same process as rift. |
|
as for more items maybe we could make it so that you can define buttons in the config. similarly to a hotkey but something like this: [menubar.items]
"Toggle Current Space" = "toggle_space_activated"with the key being what the menu item is named |
|
Ok, so can I ask someone to check if the show mission control spaces bit works for them? I have a feeling that the code is correct, but the problem is that the show mission control from the menu is not having anything happen for me.. like literally nothing... Rift just stops working and I have no clue why. |
don't use riftmachclient. just take a tx to send the command to the reactor. its crashing because you are creating a mach client in the same process as the mach server. sorry i wasn't more clear in my earlier comment. |
|
I'm a bit busy atm with schoolwork so i'll work on this in a few weeks from now. If anybody wants to work on it they can |
2 participants
This improves the menu bar / status bar / tray icon for rift by adding a small menu with 2 options:
#223 -> relevant discussion inspiring this PR (although not a lot)
Just 1 thing to clear out, I tried using a Client (
RiftMachClient) but for some reason after I did this, Rift would start, but the "Rift by default is not activated..." message doesn't appear. Hence why the showing mission control is astd::process::Command(line 59 src/ui/menubar.rs)However, the menu feels a bit empty..
Initially I thought of making it where each workspace would be one button and clicking on each of the buttons would focus onto the respective workspace. Maybe this could be discussed more as well (I have a almost working version for this locally)