Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify syntax for githubConfigSecret #3812

Merged
merged 3 commits into from
Jan 21, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed grammar
jww3 authored Nov 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 4a9ec71aed71b64b1d4cb65cc0dfe67e978140bb
2 changes: 1 addition & 1 deletion charts/gha-runner-scale-set/values.yaml
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
## ex: https://github.com/myorg/myrepo or https://github.com/myorg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any specific configuration setting(s) that could also be supplied as examples when Authenticating ARC with a personal access token (classic) that could be possible clarifying text for "githubConfigUrl: """?

## githubConfigUrl is the GitHub url for where you want to configure runners
## ex: https://github.com/myorg/myrepo or https://github.com/myorg
githubConfigUrl: ""

e.g. if yes, what is the string format?

https://github.com/enterprises/myenterprise

?

githubConfigUrl: ""

## githubConfigSecret is the k8s secrets to use when authenticating via the GitHub API.
## githubConfigSecret is the k8s secret information to use when authenticating via the GitHub API.
## You can choose to supply:
## A) a PAT token,
## B) a GitHub App, or