Add experimentalFeatures to initialization options #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a feature flagging system for opt-in experimental features. Clients can enable features via initializationOptions.experimentalFeatures with granular per-feature control or an 'all' flag to enable everything. First experimental feature: missingInputsQuickfix (for upcoming code actions)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a feature flagging system for experimental features in the language server. Clients can enable features via initializationOptions.experimentalFeatures with granular per-feature control or an all flag to enable everything. The first experimental feature defined is missingInputsQuickfix for an upcoming code actions feature.
Key changes:
- Added
ExperimentalFeaturesinterface to define feature flags with precedence rules - Implemented
FeatureFlagsclass to check and list enabled experimental features - Integrated feature flags into the connection initialization with informational logging
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| languageserver/src/initializationOptions.ts | Adds ExperimentalFeatures interface with all and missingInputsQuickfix flags, and includes it in InitializationOptions |
| languageserver/src/features.ts | Implements FeatureFlags class to manage feature flag resolution with proper precedence handling |
| languageserver/src/features.test.ts | Adds comprehensive test coverage for feature flag resolution logic and precedence rules |
| languageserver/src/connection.ts | Integrates feature flags initialization and logs enabled experimental features on server startup |
| languageserver/README.md | Documents the experimental features system with usage examples and available features table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
salmanmkc
previously approved these changes
Jan 5, 2026
ericsciple
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a feature flagging system for opt-in experimental features. Clients can enable features via initializationOptions.experimentalFeatures with granular per-feature control or an 'all' flag to enable everything.
This includes the first experimental feature: missingInputsQuickfix (for upcoming code actions/first quick fix).