Skip to content

Conversation

@littleniannian
Copy link
Collaborator

@littleniannian littleniannian commented Jan 7, 2026

User description

关联的 issue

https://github.com/actiontech/sqle-ee/issues/2615

描述你的变更

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc


Description

  • 新增总执行时间(μs)的本地化支持

  • 更新中英文locale配置文件

  • 提升微秒级别执行时间指标的显示准确性


Diagram Walkthrough

flowchart LR
  A["sqle/locale/message_zh.go新增消息"] --> B["sqle/locale/active.en.toml更新英文项"]
  A --> C["sqle/locale/active.zh.toml更新中文项"]
Loading

File Walkthrough

Relevant files
Enhancement
message_zh.go
添加中文总执行时间(μs)消息                                                                                   

sqle/locale/message_zh.go

  • 新增总执行时间(μs)的中文本地化消息
+1/-0     
active.en.toml
更新英文locale配置                                                                                         

sqle/locale/active.en.toml

  • 添加总执行时间(μs)的英文本地化支持
+1/-0     
active.zh.toml
更新中文locale配置                                                                                         

sqle/locale/active.zh.toml

  • 增加总执行时间(μs)的中文本地化描述
+1/-0     

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

PR Reviewer Guide 🔍

🎫 Ticket compliance analysis 🔶

2615 - Partially compliant

Compliant requirements:

  • 支持微秒级别的执行时间本地化显示
  • 更新中英文 locale 配置文件
  • 提升执行时间指标显示的准确性

Non-compliant requirements:

(空)

Requires further human verification:

(空)

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

文案一致性

请检查新增的本地化文案在整体文案风格与其他语言版本中是否一致,确保微秒单位描述准确。

ApMetricNameDBUser                  = &i18n.Message{ID: "ApMetricNameDBUser", Other: "用户"}
ApMetricUserClientIP                = &i18n.Message{ID: "ApMetricUserClientIP", Other: "客户端IP"}
ApMetricNameHost                    = &i18n.Message{ID: "ApMetricNameHost", Other: "主机"}
ApMetricNameMetaName                = &i18n.Message{ID: "ApMetricNameMetaName", Other: "对象名称"}
ApMetricNameMetaType                = &i18n.Message{ID: "ApMetricNameMetaType", Other: "对象类型"}
ApMetricNameQueryTimeTotal          = &i18n.Message{ID: "ApMetricNameQueryTimeTotal", Other: "总执行时间(s)"}
ApMetricNameQueryTimeAvg            = &i18n.Message{ID: "ApMetricNameQueryTimeAvg", Other: "平均执行时间(s)"}
ApMetricNameQueryTimeTotalMS        = &i18n.Message{ID: "ApMetricNameQueryTimeTotalMS", Other: "总执行时间(ms)"}
ApMetricNameQueryTimeTotalUS        = &i18n.Message{ID: "ApMetricNameQueryTimeTotalUS", Other: "总执行时间(μs)"}
文案一致性

请确认新增的英文文案与其他语言配置中的描述相匹配,保持描述统一性。

ApMetricNameQueryTimeMax = "Max execution time(s)"
ApMetricNameQueryTimeMaxMS = "Max execution time(ms)"
ApMetricNameQueryTimeTotal = "Total execution time(s)"
ApMetricNameQueryTimeTotalMS = "Total execution time(ms)"
ApMetricNameQueryTimeTotalUS = "Total execution time(μs)"
ApMetricNameRowExaminedAvg = "Average examined rows"
文案一致性

请确认新增的中文文案符合预期,并与 message_zh.go 文件中的描述保持一致。

ApMetricNameQueryTimeAvgMoreThan = "平均执行时间(s) > "
ApMetricNameQueryTimeMax = "最长执行时间(s)"
ApMetricNameQueryTimeMaxMS = "最长执行时间(ms)"
ApMetricNameQueryTimeTotal = "总执行时间(s)"
ApMetricNameQueryTimeTotalUS = "总执行时间(μs)"
ApMetricNameQueryTimeTotalMS = "总执行时间(ms)"

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@LordofAvernus LordofAvernus merged commit 0c84bcc into main Jan 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants