Fixes/sugarlabs#650 Needless double GET of favicon

ad1tyayadav · Jan 20, 2025 · dd3c09e · dd3c09e
1 parent b71fa69
commit dd3c09e
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/js/main.js b/js/main.js
@@ -12,27 +12,26 @@ $(document).ready(function () {
     var selectedColors = COLORS[colorIndex];
 
     //Apply selected colors to the Sugarlabs logo
-    var logoID = colorIndex + 1;
-    if (logoID < 10) {
-        logoID = "0" + logoID;
-    }
-
     var defaultIcon = document.querySelector('#defaultIcon1');
     if (defaultIcon) {
         var logoID = colorIndex + 1;
         if (logoID < 10) {
             logoID = "0" + logoID;
         }
-        
+
         var rootUrl = '';
         var baseTag = document.querySelector('base');
         if (baseTag && baseTag.href) {
             rootUrl = baseTag.href;
         } else {
             rootUrl = window.location.protocol + '//' + window.location.host + '/';
         }
-
-        defaultIcon.href = rootUrl + 'assets/favicon_' + logoID + '.png';
+
+        // Update the favicon
+        var newFaviconUrl = rootUrl + 'assets/favicon_' + logoID + '.png';
+        if (defaultIcon.href !== newFaviconUrl) {
+            defaultIcon.href = newFaviconUrl;
+        }
     }
 
     var h = document.querySelector('.logo1').innerHTML;