Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.16.0: ada 3.0.0 #101

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Version 1.16.0: ada 3.0.0 #101

wants to merge 11 commits into from

Conversation

bbayles
Copy link
Collaborator

@bbayles bbayles commented Jan 30, 2025

This PR upgrades to the latest version of ada, 3.0.0.

@TkTech
Copy link

TkTech commented Jan 30, 2025

I went through this same process yesterday, debugging actions kinda sucks. Have you seen https://github.com/nektos/act?

@bbayles
Copy link
Collaborator Author

bbayles commented Jan 30, 2025

@jameshilliard - you were very helpful on debugging the cibuildwheel piece before. Do you know how to make it use g++12 properly when building on Linux? Usually I have the most trouble with Windows, but today it's Linux.

@anonrig
Copy link
Member

anonrig commented Jan 30, 2025

Have you tried actually installing gcc-12 using sudo apt install gcc-12?

@jameshilliard
Copy link
Contributor

Do you know how to make it use g++12 properly when building on Linux?

Hmm, pretty sure the CXX env variable controls which c++ compiler is used by setuptools.

@anonrig
Copy link
Member

anonrig commented Jan 30, 2025

Do you know how to make it use g++12 properly when building on Linux?

Hmm, pretty sure the CXX env variable controls which c++ compiler is used by setuptools.

Yes but if gcc-12 is not installed then g++-12 will not be available.

@anonrig
Copy link
Member

anonrig commented Jan 30, 2025

Actually the error message agrees with me

error: command 'g++-12' failed: No such file or directory

@jameshilliard
Copy link
Contributor

Yes but if gcc-12 is not installed then g++-12 will not be available.

Install it using github actions then?

@bbayles
Copy link
Collaborator Author

bbayles commented Jan 30, 2025

Tried installing it here...

@jameshilliard
Copy link
Contributor

Hmm, might be a cibuildwheel limitation:

manylinux2010 and manylinux2014 are newer and support all C++ standards (up to C++17).

@bbayles
Copy link
Collaborator Author

bbayles commented Jan 30, 2025

More on that theory: pypa/cibuildwheel#984 (reply in thread)

@TkTech
Copy link

TkTech commented Jan 30, 2025

Debugging on a phone so bear with me - This isn't quite doing anything. The manylinux wheels build inside a container cibuildwheel sets up, and so anything you install on the host like this won't do anything. There's a CIBW_ envvar to provide commands to run inside the container before they run

@TkTech
Copy link

TkTech commented Jan 30, 2025

@anonrig
Copy link
Member

anonrig commented Jan 30, 2025

FYI, I just released v3.0.1 with a fix addressing a LLVM bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants