Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to Unicode 15.1 #46

Merged
merged 3 commits into from
Dec 6, 2024
Merged

updating to Unicode 15.1 #46

merged 3 commits into from
Dec 6, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented Dec 4, 2024

Unicode 16 came out in September 2024. We can update to it, but our tests cannot pass because IdnaTestV2 is still at Unicode 15. See web-platform-tests/wpt#48301

However, we can try 15.1.0.

Previously, "\u1E9E" would map to double-s and it now maps to "xn--zca". I have added a test for this specific change. This is the change that triggers the failures in ada-url/ada#794

@anonrig
Copy link
Member

anonrig commented Dec 5, 2024

It seems the new changes are from Unicode 15.1

@lemire
Copy link
Member Author

lemire commented Dec 6, 2024

It seems the new changes are from Unicode 15.1

Hmmm. Ok. Let us try.

@lemire lemire changed the title updating to Unicode 16 updating to Unicode 15.1 Dec 6, 2024
@lemire lemire requested a review from anonrig December 6, 2024 01:28
@lemire
Copy link
Member Author

lemire commented Dec 6, 2024

@anonrig Please consider this PR. It might do what we need.

Note that we need to be careful when releasing because we are bumping the Unicode version which will definitively break some things for some people.

@anonrig
Copy link
Member

anonrig commented Dec 6, 2024

@anonrig Please consider this PR. It might do what we need.

Note that we need to be careful when releasing because we are bumping the Unicode version which will definitively break some things for some people.

We can release this version as as part of Ada v3.0. Since it's a major version, we might get away with any breakings due to the unicode bump

@anonrig
Copy link
Member

anonrig commented Dec 6, 2024

@lemire it seems windows is unhappy

Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@anonrig anonrig merged commit ab36768 into main Dec 6, 2024
27 checks passed
@anonrig anonrig deleted the unicode16 branch December 6, 2024 01:44
@lemire
Copy link
Member Author

lemire commented Dec 6, 2024

it seems windows is unhappy

I coded a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants