Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector media buttons #140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Vector media buttons #140

wants to merge 2 commits into from

Conversation

hsaturn
Copy link

@hsaturn hsaturn commented Apr 13, 2021

  • Describe the scope of your change--i.e. what the change does and what parts
    of the code were modified.
    This will help us understand any risks of integrating
    the code.

Instead of having hard-coded coordinates, let's compute the coords.
I was tired of seeing too large buttons for my 0.96 oled display.

The risk is to have mediabuttons bad or not displayed. No other impact.

  • Describe any known limitations with your change. For example if the change
    doesn't apply to a supported platform of the library please mention it.

I've removed the delay(...) as I really do not see what this gives to the demo.

  • Please run any tests or examples that can exercise your modified code. We
    strive to not break users of the code and running tests/examples helps with this
    process.

There is no risk at all that that PR breaks any existing code. (only the example itself)

Instead of having hard-coded coordinates, let's compute the coords.

I was tired of seeing too large buttons for my 0.96 oled display.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant