-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix iter issues #7
Conversation
tests/test_json_stream.py
Outdated
|
||
|
||
def test_as_object_grabbing_multiple_subscriptable_levels_twice_raises(complex_dict): | ||
"""Test loading a complex dict and grabbing multiple subscriptable levels twice raises.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this work not fail, assuming the keys are ordered and the user hasn't left [asked for later data] the current parent object?
If not then what is the correct usage, to request the parent object separately first and then subscript that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are any other tests we can think to add, I'll put them in. Then use those tests to update docs as to what can and can't be done |
Thanks for working on that. Seems good to me. |
Good catch. I think I added it while working through things and it was before I had |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for improving this! I really appreciate it. Just a couple small things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One documentation request. Looks good otherwise. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This fixes some issues when grabbing the last key, or lists of single items when the
,
doesn't exist._IterToStream.last_char
to allowTransient
to see what it really ended onTransientList
andTransientObject
into the base classTransient.as_object
so you can get the entire object