Issue #126

[jinglemansweep]

Added bytearray('\x00') to the list of expected "noop" returns from the socket.

[dhalbert]

THanks! One question.

[dhalbert]

Use pre-commit or run the code through black to get rid of the failure: https://learn.adafruit.com/improve-your-code-with-pylint

[dhalbert]

I'm wondering whether the fact that you have to check for one byte of zeros is a bug in the underlying network code. But I think this is a good workaround to add to the library for now.

@brentru Do you have any comment about this from an MQTT protocol point of view?

[brentru]

@jinglemansweep Hi - thanks for fixing this issue. @dhalbert - I do not think this is a network or a MQTT spec issue, b"\x00 is rx'd after the call to res = self._sock_exact_recv(1).

Considering some in #126 are having issues with non-native wifi, it's possible (don't know, guessing right now) that the issue is within this library's local implementation of _sock_exact_recv() vs the native impl. of _sock_exact_recv() (cc @calcut ☝️ )

        # CPython socket module contains a timeout attribute
        if hasattr(self._socket_pool, "timeout"):
            try:
                res = self._sock_exact_recv(1)
            except self._socket_pool.timeout:
                return None
        else:  # socketpool, esp32spi
            try:
                res = self._sock_exact_recv(1)

[brentru]

For now, though, I think this is an OK temporary change and will cause clients to poll faster until we resolve why the socket is rcv'ing a bytearray on some clients.