Don't retry when MQTT response is unauthorized #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brentru willing to take a look? |
justmobilize
commented
May 14, 2024
|
I defer to @brentru on this. |
justmobilize
commented
May 20, 2024
dhalbert
requested changes
May 20, 2024
|
@dhalbert So this shouldn't really solve anything other then getting a better error, and making it easier to debug. Unless the error they get is really retriable (which I asked above) |
dhalbert
approved these changes
May 20, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 21, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.8.0 from 7.7.0: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#190 from vladak/recv_timeout_vs_keep_alive > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#213 from justmobilize/no-retry-on-unauthorized Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update connection code to break out of the retry look when getting either a
Incorrect username/passwordorUnauthorizedresponse.Noticed in #211, although doesn't fix the original post
Tested on a
UM FeatherS3