Skip to content

Commit

Permalink
Merge pull request #108 from MarkTsengTW/MarkTsengTW-patch-for-issue-104
Browse files Browse the repository at this point in the history
Proposed solution for Issue #104: multiple cookies
  • Loading branch information
FoamyGuy authored Apr 18, 2022
2 parents 7ac2df5 + b726db5 commit 2e6b3f9
Show file tree
Hide file tree
Showing 2 changed files with 62 additions and 1 deletion.
5 changes: 4 additions & 1 deletion adafruit_requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,10 @@ def _parse_headers(self) -> None:
self._remaining = int(content)
if title == "transfer-encoding":
self._chunked = content.strip().lower() == "chunked"
self._headers[title] = content
if title == "set-cookie" and title in self._headers:
self._headers[title] += ", " + content
else:
self._headers[title] = content

def _validate_not_gzip(self) -> None:
"""gzip encoding is not supported. Raise an exception if found."""
Expand Down
58 changes: 58 additions & 0 deletions examples/requests_multiple_cookies.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
# SPDX-FileCopyrightText: 2022 Alec Delaney
# SPDX-License-Identifier: MIT

"""
This example was written for the MagTag; changes may be needed
for connecting to the internet depending on your device.
"""

import ssl
import wifi
import socketpool
import adafruit_requests

COOKIE_TEST_URL = "https://www.adafruit.com"

# Get wifi details and more from a secrets.py file
try:
from secrets import secrets
except ImportError:
print("WiFi secrets are kept in secrets.py, please add them there!")
raise

# Connect to the Wi-Fi network
print("Connecting to %s" % secrets["ssid"])
wifi.radio.connect(secrets["ssid"], secrets["password"])

# Set up the requests library
pool = socketpool.SocketPool(wifi.radio)
requests = adafruit_requests.Session(pool, ssl.create_default_context())

# GET from the URL
print("Fetching multiple cookies from", COOKIE_TEST_URL)
response = requests.get(COOKIE_TEST_URL)

# Spilt up the cookies by ", "
elements = response.headers["set-cookie"].split(", ")

# NOTE: Some cookies use ", " when describing dates. This code will iterate through
# the previously split up 'set-cookie' header value and piece back together cookies
# that were accidentally split up for this reason
days_of_week = ("Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat")
elements_iter = iter(elements)
cookie_list = []
for element in elements_iter:
captured_day = [day for day in days_of_week if element.endswith(day)]
if captured_day:
cookie_list.append(element + ", " + next(elements_iter))
else:
cookie_list.append(element)

# Pring the information about the cookies
print("Number of cookies:", len(cookie_list))
print("")
print("Cookies received:")
print("-" * 40)
for cookie in cookie_list:
print(cookie)
print("-" * 40)

0 comments on commit 2e6b3f9

Please sign in to comment.