Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for render functions chunk_size parameter and negative skipped linesin error message #5

Merged
merged 5 commits into from
Nov 2, 2024

Conversation

michalpokusa
Copy link
Contributor

@michalpokusa michalpokusa commented Oct 30, 2024

🪛Fixes:

  • Removed unnecessary _yield_as_sized_chunks in render_... functions
  • Added check for skipped lines in TemplateSyntaxError to avoid messages like "[-1 lines skipped]"

🏗️ Refactor:

  • Renamed _CACHE to CACHED_TEMPLATES

@michalpokusa michalpokusa changed the title Fixes and refactor Fixes for render functions chunk_size parameter and negative skipped linesin error message Oct 30, 2024
@michalpokusa michalpokusa marked this pull request as ready for review October 31, 2024 00:04
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I tested successfully with a modified simpletest on a Feather S3 TFT.

@FoamyGuy FoamyGuy merged commit be78fc3 into adafruit:main Nov 2, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 3, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint to 2.2.17 from 2.2.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_Fingerprint#55 from itsFDavid/compare_with_file

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L1X to 1.2.0 from 1.1.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L1X#20 from TheIllusionist77/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.1.5 from 3.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#210 from shubham0x13/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_TemplateEngine to 2.0.2 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_TemplateEngine#5 from michalpokusa/fixes-and-refactor

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
@michalpokusa michalpokusa deleted the fixes-and-refactor branch December 20, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants