-
Notifications
You must be signed in to change notification settings - Fork 791
Update PyPaint learn guide files for use with Fruit Jam OS #3104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to make a new version of this script instead of updating the existing one. Can you move the new one into a new folder inside of https://github.com/adafruit/Adafruit_Learning_System_Guides/tree/main/Fruit_Jam and then revert the original one back please?
That way those other devices don't end up with code involving mice that could be confusing for people working through the guides on the original hardware that it supported.
Sure 😁. Let me know if this is what you were thinking or if there are any other suggestions.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving this. One request to remove the touchscreen handling from this version, and question / suggestion for mouse handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tested successfully in fruit jam os with same mouse as before and all is good now.
Thanks for adapting this project and working through everything!
This PR updates the PyPaint Learn Guide program files (https://learn.adafruit.com/pypaint/overview) to allow the program to run on the Fruit Jam.
I have to thank @jedgarpark for the Larsio_Paint_Music program, as I lifted most of the usb mouse code from that program to be used here.
I don't think any of the code changes I made will impact the PyPortal, PyBadge or PyGamer (the boards the learn guide indicates it supports) however the changes probably have a memory impact and I don't have any of the devices in question to test. That being said, given the memory increase in CircuitPython since those boards were released, I wonder if the non-modified learn code still fits in RAM.
In addition to adding the display and mouse support for the Fruit Jam, I also added an area fill function, using the right mouse button. If you try out the fill, you can make it run much faster by clicking to the upper left of the area you want to fill.