Monster M4sk: user control of eyes, user config from config.eye, user wiichuck control eyes&neopixels #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: eyesWide, eyesBlink, eyesToCorner, eyesNormal file.cpp: add additional user_setup function that passes in the configuration file.cpp: add some accessor functions that use dwim() globals.h: declarations of new functions user_watch.cpp: fix case on HeatSensor.h for case-sensitive compilation systems user_watch.cpp: convert to using new eyesToCorner() user_*.cpp: add user_setup(doc) function new user_wiichuck.cpp: connects to WiiChuck that controls eyes and NeoPixel strip
TonyLHansen
changed the title
|
@ladyada, can another reviewer be assigned to this PR? |
|
hi, there's no other reviewers available, we don't have guaranteed ETAs for merging contributor projects. thank u! |
|
@ladyada Thanks for the reply; I figured it was worth asking. I’ll keep rebasing the PR once in a while until it gets merged. |
ARDUINOJSON_ENABLE_COMMENTS must be set to 1 before including the library. The same value of ARDUINOJSON_ENABLE_COMMENTS must be set in each compilation unit.
Added additional eye functions (close, wide), to replace boop and blink functions on the Wiichuck button functions for better eye puppetry. Other minor style and debugging changes.
Additional eye type for eagles and other birds of prey. Eyelids are *inverted*, eagles blink up as their top eyelid is larger than the bottom one!
Improved configuration documentation of eagle eyes. Minor updates to debugging output.
|
This one isn't passing lint checks |
Fixes to wiichuck support and upstream compilation checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M4_Eyes.ino: add a set of user_callable functions to control the eyes: eyesWide, eyesBlink, eyesToCorner, eyesNormal
file.cpp: add additional user_setup function that passes in the configuration
file.cpp: add some accessor functions that use dwim()
globals.h: declarations of new functions
user_watch.cpp: fix case on HeatSensor.h for case-sensitive compilation systems
user_watch.cpp: convert to using new eyesToCorner()
user_*.cpp: add user_setup(doc) function
new user_wiichuck.cpp: connects to WiiChuck that controls eyes and NeoPixel strip