Support large packet publishing with ESP8266#113
Open
hjf wants to merge 1 commit intoadafruit:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending large packets with ESP8266's WiFiClient, the library prints a couple hundred bytes and then garbage. The Adafruit library sends 250 bytes at a time to publish the packet. This is where it fails. Fortunately, ESP8266's implementation of Client supports large packets by itself. It will take care of splitting data even beyond the IP packet's MTU.
This fix conditionally enables sending the complete package to WiFiClient with a simple IFDEF ESP8266.
Tested on Arduino 1.8.5.