Include Waveshare RP2040 One (3 of 3) #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
requested changes
Aug 8, 2024
adafruit_platformdetect/board.py
Outdated
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| from adafruit_platformdetect.constants import boards, chips | |||
|
|
|||
| __version__ = "0.0.0+auto.0" | |||
| __version__ = "3.72.1" | |||
There was a problem hiding this comment.
Please change this back to 0.0.0+auto.0. The versioning is automatically changed this way.
adafruit_platformdetect/chip.py
Outdated
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| from adafruit_platformdetect.constants import chips | |||
|
|
|||
| __version__ = "0.0.0+auto.0" | |||
| __version__ = "3.72.1" | |||
There was a problem hiding this comment.
Please change this back to 0.0.0+auto.0 as well.
| 0x812E, | ||
| 0x8130, | ||
| 0x0105, | ||
| ( |
There was a problem hiding this comment.
Can we remove the extra set of parenthesis?
makes suggested changes
makes suggested changes: version as '0.0.0+auto.0' and removes superfluous parenthesis
johnnohj
commented
Aug 8, 2024
|
Checks are stumbling over Black formatting, which insists on the extra level of parentheses wrapping the (now) three groups of vendor/product ids |
Fair enough. We can leave it then. |
makermelissa
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a trio of PRs to see support for the RP2040 One extended; I think it could be useful as an inexpensive entry to testing out sensors or debugging in light of articles such as:
https://learn.adafruit.com/circuitpython-libraries-on-any-computer-with-raspberry-pi-pico
Companion pull requests:
adafruit/u2if#11