You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to implement the Notification endpoint in the CDC ACM spec so we can send hardware flow control signals up to the host.
Draft for now. I'm looking for code reviews. For the obvious stuff: style, improvements, etc.
But also: It doesn't work yet. My computer doesn't seem to be sending events to the Notification endpoint. At least, my code doesn't seem to be getting triggered at all.
I am NOT an expert at USB stack coding (this is my first time.) I'm hoping there's a simple "Oh, you forgot that it's Thursday. You need to flip this bit and tickle that widget and poke this bear, and it'll work."
There's some extra debugging code in here that I'll remove before fully submitting the PR; it's in there for testing.
Figured it out. I was queueing the notification in the callback, which only gets called after the notification is sent. I moved the queueing to set_serial_state instead, and call it again from the call back in case the state changed while we were notifying of the last change.
I had to move #include "Adafruit_USBD_CDC.h" before #include "Arduino.h" so that it would include my locally modified version, instead of the version that's included in architecture core libraries. Otherwise, automatic checks in github were failing.
Let me know if you'd prefer to accept the build-check failures and keep the #include where it is.
SmittyHalibut
changed the title
CDC Notification Endpoint, so we can send CTS/DSR/DCD/RI.
CDC Notification Endpoint, so we can send DSR/DCD/RI.
Mar 1, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SmittyHalibut
changed the title
See #491
The goal is to implement the Notification endpoint in the CDC ACM spec so we can send hardware flow control signals up to the host.
Draft for now. I'm looking for code reviews. For the obvious stuff: style, improvements, etc.But also: It doesn't work yet. My computer doesn't seem to be sending events to the Notification endpoint. At least, my code doesn't seem to be getting triggered at all.I am NOT an expert at USB stack coding (this is my first time.) I'm hoping there's a simple "Oh, you forgot that it's Thursday. You need to flip this bit and tickle that widget and poke this bear, and it'll work."There's some extra debugging code in here that I'll remove before fully submitting the PR; it's in there for testing.Figured it out; see below.