-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tinyusb to commit 334ac8072650e3b18278042c2c2b402db73c7359 #498
Update tinyusb to commit 334ac8072650e3b18278042c2c2b402db73c7359 #498
Conversation
hathach
commented
Feb 26, 2025
•
edited
Loading
edited
- update tinyusb core to hathach/tinyusb@334ac80
- feat(esp32) resolve conflict with latest v3.1.3. better enforce tusb_config_esp32.h within tusb_option.h
- also change CFG_TUD_MIDI_RX/TX_BUFSIZE for rp2040 to 64
- change to "SdFat_Adafruit_Fork.h" and revert to build sdfat example
7e972ba
to
2112075
Compare
…afruit's Fork of SdFat
2112075
to
aba2328
Compare
@hathach I imagine you will get to this soon anyway, but any chance you can include the latest espressif patch too over in hathatch/tinyUSB please, seems to be blowing up on arduino-esp32 3.2.0-rc.1 |
would you mind telling me which patch you are referring to ? I am happy to include it. |
I was guessing [didn't look properly, just had a build issue in CI] the one
you merged today/yesterday mentioning espressif that removed some now
unnecessary dependency. On the phone now just before bed but will dig out
the failed job and look properly in the morning. It's probably unrelated, I
just had troubles building wippersnapper on 3.2.0-rc.1, saw a related error
and thought maybe an upstream fix was in the works. I should've saved and
included the error 😔
…On Fri, 28 Feb 2025, 03:09 Ha Thach, ***@***.***> wrote:
@hathach <https://github.com/hathach> I imagine you will get to this soon
anyway, but any chance you can include the latest espressif patch too over
in hathatch/tinyUSB please, seems to be blowing up on arduino-esp32
3.2.0-rc.1
would you mind telling me which patch you are referring to ? I am happy to
include it.
—
Reply to this email directly, view it on GitHub
<#498 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ46DOCAYBCPLRULVMYL2R7HNFAVCNFSM6AAAAABX4VLCD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBZGYYTENJSGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: hathach]*hathach* left a comment
(adafruit/Adafruit_TinyUSB_Arduino#498)
<#498 (comment)>
@hathach <https://github.com/hathach> I imagine you will get to this soon
anyway, but any chance you can include the latest espressif patch too over
in hathatch/tinyUSB please, seems to be blowing up on arduino-esp32
3.2.0-rc.1
would you mind telling me which patch you are referring to ? I am happy to
include it.
—
Reply to this email directly, view it on GitHub
<#498 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ46DOCAYBCPLRULVMYL2R7HNFAVCNFSM6AAAAABX4VLCD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBZGYYTENJSGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Ah I will surely fix the ci for esp before merging. This is just quick hacked pr so that Jeff can use latest tinyusb code to test with the rp2350 |
5ffad94
to
41bde22
Compare
…config_esp32.h within tusb_option.h also change CFG_TUD_MIDI_RX/TX_BUFSIZE for rp2040 to 64
7547e6e
to
1d3576a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyeth pr is updated to resolve compile conflict with arduino-esp32 3.1.3. tested with both s2 and s3
This comment has been minimized.
This comment has been minimized.
Thanks @hathach you're a star ✨ |