LPS28 branch I2c Fix for S2, BSP Arduino-ESP32 3.1.3 Earle Core RP2xxx 4.4.1 #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
param mode true for FS_MODE=1 (1/2048 hPa/LSB), false for FS_MODE=0 (1/4096 hPa/LSB)
tyeth
changed the title
|
@brentru have a look at the I2C changes, and know that there is a corresponding branch in ci-arduino (not worth review) |
Merged
brentru
requested changes
Mar 3, 2025
| @@ -34,7 +34,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
There was a problem hiding this comment.
Revert these changes and pull main, in favor of solution #706
| @@ -156,22 +156,37 @@ WipperSnapper_Component_I2C::scanAddresses() { | |||
|
|
|||
| // Scan all I2C addresses between 0x08 and 0x7F inclusive and return a list of | |||
| // those that respond. | |||
| uint8_t addresses_failed_count = 0, current_failed_count = 0; | |||
There was a problem hiding this comment.
Yeah this branch/PR was to get the build passing for LPS28 (as related to RP2040) along with test i2c scan changes in relation to #700
Probably worth closing once we have a solution for I2C, or I can cherry pick that out to a new PR / replace this PR.
| and pressure sensor. | ||
| */ | ||
| /**************************************************************************/ | ||
| class WipperSnapper_I2C_Driver_LPS28DFW : public WipperSnapper_I2C_Driver { |
There was a problem hiding this comment.
Does this driver require the changes to _I2C.cpp in this PR?
|
Going to drop this, moved I2C to another PR, the RP2040 is solved / an SdFat situation, and the LPS28 is already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates BSP to
3.2.0-rc.1, and leaves RP2xxx at 4.4.4 / latest3.1.3, and pin Earle at 4.4.1 for now until earlephilhower/arduino-pico#2828 (comment) is resolved