Fix Issues: Pixel and Status Pixel #708
Conversation
| // to INPUT. | ||
| #ifdef ARDUINO_ARCH_ESP32 | ||
| // Release the rmtPin for use by other peripherals | ||
| statusPixel->updateLength(0); |
There was a problem hiding this comment.
Not sure this works on all platforms [updateLength 0 then show], and the docs mention it is deprecated but left for old projects that may be calling it.
There was a problem hiding this comment.
This access to the RMT is only for ESP32 and is guarded, am I missing something?
There was a problem hiding this comment.
No, I guess my brain was still coming from the perspective of the neopixel repo when making those comments.
I'm happy (actually extremely grateful) for this fix, but also wonder if the docs comments in neopixel repo suggest not using updateLength and using new NeoPixel(length, instead then is this the right move. Let's merge it and keep the neopixel repo issue to that repo.
There was a problem hiding this comment.
We can't merge til neopixel repo is merged fwiw
|
@tyeth Can I re-request a review for this? |
Fixes #691 and #684 via resolving a bug in Adafruit_NeoPixel and adding additional code in the application to handle RMT de-initialization.
This pull request requires the following pull request to be approved, merged, and released before merging:
adafruit/Adafruit_NeoPixel#424
This pull request resolves: