-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SDFat conflict with Arduino-Pico BSP #31
Conversation
b700ad7
to
3aff08c
Compare
@ladyada Requesting a re-review. This adds a file and bumps the semver. It should not break anything that is not already failing. We'd want to eventually fix the lib. CI by updating the examples. This looks good and builds for WipperSnapper after I changed the inclusion to reflect the fork header (build log) @hathach I saw that you had the same issue with TinyUSB_Arduino and disabled the RP2040 build target too. You may want to implement the same thing we did in WipperSnapper ☝️ |
@ladyada @brentru yeah, indeed, arduino-pico now include official SdFat in the core/libraries as builtin, which has higher priority in library name matching. The way arduino ide/cli find matched library with the same header include i.e SdFat.h when having a few candidates is using name matching: I will re-investigate find more solution, but we have a few approaches that I have in mind now:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, I commented in hurry and didn't realize you already create a new header. That I think is the great solution, it will probably take it some time to mirgate but that ensure it will work in the future.
Once thing to consider is to just name the new header as Adafruit_Sdfat.h
with the includes field, the arduino-cli should be able to detect and know where to find the library. But it is up to you and @ladyada to decide :)
yeah i think its better to keep this name, so its clear - in case some day in the future we have our own adafruit_sdfat library or something |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good now, there is a sligth concern above. For CI, I think we can skip the failed test with rp2040, since that need TinyUSB to be update, and TinyUSB need this to be released first (mutual recusrive :) )
@brentru just merged and released, sorry for a bit hurry since this block other ci such as brain and tinyusb to run tests properly. |
@ladyada This PR resolves earlephilhower/arduino-pico#2828 (comment)
by implementing the following fix proposed by earlephilhower:
I will create a new release of Adafruit/SDFat after this PR is merged.