Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build board info #10121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 6, 2025

Use board mapping instead of looking for directories

Use board mapping instead of looking for directories
@tannewt tannewt requested a review from Neradoc March 6, 2025 21:56
Copy link

@Neradoc Neradoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alias boards get double the versions, because they are already in board_mapping.
So you don't need the inner loop on alias:

    for board_id, board_info in board_mapping.items():
        if board_id not in current_info:
            changes["new_boards"].append(board_id)
            current_info[board_id] = {"downloads": 0, "versions": []}
        new_version = {
            "stable": new_stable,
            "version": new_tag,
            "languages": languages,
            # add modules, extensions, frozen_libraries explicitly
            "modules": support_matrix[board_id]["modules"],
            "extensions": support_matrix[board_id]["extensions"],
            "frozen_libraries": support_matrix[board_id]["frozen_libraries"],
        }
        current_info[board_id]["downloads"] = board_info["download_count"]
        current_info[board_id]["versions"].append(new_version)

With this, it seems all good from what I've been able to see by comparing to the last version on cp.org (with more boards and new modules as expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants