Skip to content

M5Stack CoreS3 refactor/fix M5Bus pins definitions #10558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

M5Stack CoreS3 refactor/fix M5Bus pins definitions #10558

wants to merge 2 commits into from

Conversation

CDarius
Copy link

@CDarius CDarius commented Aug 8, 2025 •
edited by dhalbert
Loading

dhalbert
dhalbert requested changes Aug 8, 2025
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, two things.

  1. I2S is misspelled IS2 on some pins.
  2. Could you put blank lines before and after each multi-line set of lines with the same pin number? This makes it clearer which pin names are aliases. For example, do:
    { MP_ROM_QSTR(MP_QSTR_A6), MP_ROM_PTR(&pin_GPIO6) },

    { MP_ROM_QSTR(MP_QSTR_PORTB_IN), MP_ROM_PTR(&pin_GPIO8) },
    { MP_ROM_QSTR(MP_QSTR_D8), MP_ROM_PTR(&pin_GPIO8) },
    { MP_ROM_QSTR(MP_QSTR_A8), MP_ROM_PTR(&pin_GPIO8) },

    { MP_ROM_QSTR(MP_QSTR_D5), MP_ROM_PTR(&pin_GPIO5) },

There are multiple places to do this. Be careful your editor doesn't insert extra spaces on the blank lines: that will fail pre-commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

M5Stack Core S3 pinout error
2 participants
@CDarius @dhalbert