Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using types_or over files in pre-commit hook config #298

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jamesbraza
Copy link

@jamesbraza jamesbraza commented Oct 23, 2023

@adamchainz
Copy link
Owner

Thank you for this. Because people check their pre-commit configuration so rarely, and this may cause extra files to be formatted on upgrade, I will treat this as requiring a major version change. I’ll leave it queued up for the future.

Also, I’m tempted to remove the Jupyter notebook hook. I think it’s a bit niche and I’d hope users can comfortably configure pre-commit as they need for notebooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More general .pre-commit-hooks.yaml for Jupyter Notebooks
2 participants