feat: Add SerializersModule support to KxsTsGenerator #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the `KxsTsGenerator` to accept a `SerializersModule` in its constructor. This module is then used to resolve contextual and polymorphic serializers during the TypeScript generation process. The `SerializerDescriptorsExtractor` has been refactored to use the `SerializersModule.dumpTo` experimental API to collect all serializers from the module. This allows for a platform-independent way to handle complex serialization scenarios.
|
Thanks for the PR! It's been a while since I've worked on this project so I'll have to dust off some cobwebs (both in my recollections and the project). |
aSemy
reviewed
Sep 11, 2025
|
|
||
| companion object { | ||
|
|
||
| fun default(serializersModule: SerializersModule) = |
There was a problem hiding this comment.
serializersModule is unused here. How should it be used?
aSemy
reviewed
Sep 11, 2025
Comment on lines
+56
to
+59
| test("Example4: expect contextual serializer to be extracted") { | ||
| val module = SerializersModule { | ||
| contextual(Example4.SomeType::class, Example4.SomeType.serializer()) | ||
| } |
There was a problem hiding this comment.
This test still passes if the custom contextual(...) is commented out.
aSemy
reviewed
Sep 11, 2025
Comment on lines
+72
to
+75
| test("Example5: expect polymorphic serializer to be extracted") { | ||
| val module = SerializersModule { | ||
| polymorphic(Example5.Parent::class, Example5.SubClass::class, Example5.SubClass.serializer()) | ||
| } |
There was a problem hiding this comment.
This test still passes if the custom polymorphic(...) is commented out.
aSemy
reviewed
Sep 11, 2025
| open val sourceCodeGenerator: TsSourceCodeGenerator = TsSourceCodeGenerator.Default(config), | ||
| open val serializersModule: SerializersModule = SerializersModule { }, |
There was a problem hiding this comment.
Instead of SerializersModule { } please use EmptySerializersModule()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the
KxsTsGeneratorto accept aSerializersModulein its constructor. This module is then used to resolve contextual and polymorphic serializers during the TypeScript generation process.The
SerializerDescriptorsExtractorhas been refactored to use theSerializersModule.dumpToexperimental API to collect all serializers from the module. This allows for a platform-independent way to handle complex serialization scenarios.Closes #6