Skip to content
This repository was archived by the owner on Jul 7, 2020. It is now read-only.

add meter metrics for page cache eviction ref T67358 #256

Open
satang500 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add meter metrics for page cache eviction ref T67358 #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ace1759
add meter metrics for page cache eviction ref T67358
Jun 27, 2017
f026042
changed static
Jun 27, 2017
b530557
back to prev
Jun 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions hydra-data/src/main/java/com/addthis/hydra/data/query/engine/EngineRemovalListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import java.util.concurrent.TimeUnit;

import com.google.common.cache.RemovalCause;
import com.google.common.cache.RemovalListener;
import com.google.common.cache.RemovalNotification;

Expand All @@ -37,6 +38,18 @@ class EngineRemovalListener implements RemovalListener<String, QueryEngine> {
static final Meter directoriesEvicted = Metrics.newMeter(QueryEngineCache.class, "directoriesEvicted",
"directoriesEvicted", TimeUnit.MINUTES);

static final Meter replacedEvicted = Metrics.newMeter(QueryEngineCache.class, "ReplacedEvicted",
"ReplacedEvicted", TimeUnit.MINUTES);

static final Meter collectedEvicted = Metrics.newMeter(QueryEngineCache.class, "CollectedEvicted",
"CollectedEvicted", TimeUnit.MINUTES);

static final Meter expiredEvicted = Metrics.newMeter(QueryEngineCache.class, "ExpiredEvicted",
"ExpiredEvicted", TimeUnit.MINUTES);

static final Meter sizeEvicted = Metrics.newMeter(QueryEngineCache.class, "SizeEvicted",
"SizeEvicted", TimeUnit.MINUTES);

private final QueryEngineCache engineCache;

public EngineRemovalListener(QueryEngineCache engineCache) {
Expand All @@ -57,6 +70,13 @@ public void onRemoval(RemovalNotification<String, QueryEngine> notification) {
}
if (currentEngine == null) {
directoriesEvicted.mark();
if(notification.getCause() == RemovalCause.REPLACED) {
replacedEvicted.mark();
}
collectedEvicted.mark();
expiredEvicted.mark();
sizeEvicted.mark();

}
}
}
Expand Down
8 changes: 8 additions & 0 deletions hydra-store/src/main/java/com/addthis/hydra/store/common/PageCacheMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,15 @@
*/
package com.addthis.hydra.store.common;

import java.util.concurrent.TimeUnit;

import com.addthis.codec.codables.BytesCodable;
import com.addthis.hydra.store.nonconcurrent.NonConcurrentPageCache;

import com.yammer.metrics.Metrics;
import com.yammer.metrics.core.Gauge;
import com.yammer.metrics.core.Histogram;
import com.yammer.metrics.core.Meter;

public class PageCacheMetrics<K, V extends BytesCodable> {

Expand Down Expand Up @@ -49,6 +53,8 @@ public class PageCacheMetrics<K, V extends BytesCodable> {
// This metrics counts compressed bytes
public final Histogram numberKeysPerPage;

public static Meter pagesDeletedMeter;

public PageCacheMetrics(AbstractPageCache<K, V> cache) {
parent = cache;
memEstimateGauge = Metrics.newGauge(cache.getClass(),
Expand Down Expand Up @@ -111,6 +117,8 @@ public Long value() {
Metrics.newHistogram(cache.getClass(), "numberKeysPerPage", parent.scope) :
null;

pagesDeletedMeter = Metrics.newMeter(cache.getClass(), "pagesDeleted", "pagesDeleted", TimeUnit.MINUTES);
pagesDeletedMeter.mark();
}

}