This repository was archived by the owner on Jul 7, 2020. It is now read-only.
changed the file writing mode to avoid an empty minion.state wh… #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en restarting minion
satang500
changed the title
ranadessr
reviewed
Nov 2, 2017
| } | ||
|
|
||
| void writeState() { | ||
| void writeState(boolean append) { |
There was a problem hiding this comment.
Is append the correct thing to do? Minion state is a JSON object. If you keep appending, wont that result in invalid json in the file? Have you tested that?
ranadessr
suggested changes
Nov 2, 2017
ranadessr
left a comment
ranadessr
left a comment
There was a problem hiding this comment.
One other comment I have is that there should be logging that indicates minion.state file is empty. Currently, we find a minion did not start and then we have to look to see it was because the state file is empty
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( except when minion starts (which is the same in the original code) )
Question: There are two places where they use minionStateLock again
(run method in CommandTaskDeleteRunner and kickNextJob method in Minion)
even though writeState() is already locking via minionStateLock.
Since this is ReentrantLock, it's no harm, but wondering why they use this way.